Feat/Add 'Clear All' button to shelf#975
Conversation
Alexander5015
left a comment
Alexander5015
left a comment
There was a problem hiding this comment.
Please rebase your changes onto dev, and set the target branch to dev as well.
Ben-Lloyd05
force-pushed
the
feat/shelf-clear-all
branch
from
8c520ee to
fab9bdc
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds a "Clear All" button to the shelf feature, allowing users to remove all items at once. Additionally, it includes several other improvements such as brightness adjustment enhancements, DMG creation workflow changes, documentation updates, and issue template refinements.
Changes:
- Added "Clear All" button and right-click context menu option to the shelf interface
- Enhanced brightness adjustment with smooth transition API
- Updated DMG creation workflow to use dmgbuild tool for better customization
- Added comprehensive CONTRIBUTING.md guide and improved README
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| boringNotch/components/Shelf/Views/ShelfView.swift | Added "Clear All" button overlay and context menu with proper cleanup |
| boringNotch/components/Shelf/ViewModels/ShelfStateViewModel.swift | Implemented clearAll() method with proper resource cleanup |
| boringNotch/components/Tabs/TabSelectionView.swift | Added badge showing shelf item count |
| boringNotch/managers/BrightnessManager.swift | Refactored brightness adjustment to use new smooth API |
| BoringNotchXPCHelper/BoringNotchXPCHelper.swift | Added adjustScreenBrightness method with smooth transition support |
| boringNotch/XPCHelperClient/XPCHelperClient.swift | Added client method for brightness adjustment |
| Configuration/dmg/* | Added dmgbuild configuration and scripts for DMG creation |
| CONTRIBUTING.md | Added comprehensive contribution guidelines |
| README.md | Updated URL and simplified contribution section |
| .github/workflows/* | Updated workflows to use dmgbuild |
| .github/ISSUE_TEMPLATE/* | Added feature request form and updated bug report template |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ben-Lloyd05
force-pushed
the
feat/shelf-clear-all
branch
from
fab9bdc to
8a53235
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ons. Additionally adds a number above the shelf icon to indicate the number of files currently held in the shelf
Ben-Lloyd05
force-pushed
the
feat/shelf-clear-all
branch
from
fe13eaa to
77dcb2c
Compare
Alexander5015
left a comment
Alexander5015
left a comment
There was a problem hiding this comment.
Please update to fix merge conflicts
Fixed |
There was a problem hiding this comment.
Tab selection is intended to be generalized, don't hardcode shelf state and shelf UI into the TabSelectionView
| .clipShape(Capsule()) | ||
|
|
||
| // Badge for shelf file count | ||
| if !shelfVM.isEmpty { |
There was a problem hiding this comment.
Badge is also clipped some of the time. I know this has more to do with a layout issue (I think that shouldn't depend on closed notch height does). But until that is resolved, the badge won't show up properly for everyone and shouldn't be added. It also might be nice if this badge was optional.
| } | ||
|
|
||
| // Clear All button | ||
| Button(action: { |
There was a problem hiding this comment.
I'm not sure about this. given that it is always floating in the file view, we may want some kind of confirmation flow to prevent accidental deletion, which seems quite easy, and we may also want this floating button to be enabled/disabled by a setting in the shelf settings.
- 合入 TheBoredTeam#1112 YouTube Music 重连修复\n- 合入 TheBoredTeam#1078 Sparkle 更新通道与 nightly 发布链路\n- 合入 TheBoredTeam#1047 音乐面板显示模式\n- 合入 TheBoredTeam#1021 Shelf 多选拖拽预览（含工程文件注册修复）\n- 合入 TheBoredTeam#975 Shelf Clear All\n- 合入 TheBoredTeam#937 网易云歌词 LRC 解析增强\n- 本地执行 xcodebuild Debug 构建通过
There was a problem hiding this comment.
The user @princip requested an addition to this pr in issue #1248:
"PR #975 looks like a great addition, especially the 'Clear All' button and the file counter. However, it doesn't look like that PR includes the keyboard shortcuts (Backspace) for removing specific items or selections. I’d still love to see those implemented as well to make the shelf management feel even more efficient for macOS."
It would also be nice if the shortcut could be customized. I am happy to write the code for this if you want.
Uh oh!
There was an error while loading. Please reload this page.